xyz
Oh, I see, so if the tile is removed from the list, then it will become visible automatically?
No, that's not working... The tiles are being removed from the list but aren't becoming visible again.
Forget it, I was being dumb again.
Great news!
Thanks to you, it's working (kind of)! I still need to iron out some kinks in my raycasting I think, but tiles are appearing now!
xyz
Which part?
I got the raycasting working, but I'm still not happy with the algorithm I'm using to decide which tiles to reveal.
The code that reveals the tiles is basically exactly what you wrote:
extends TileMapLayer
var invisibletiles: Array[Vector2i]
@onready var hero = $"../../Hero"
func reveal_tile(collisionpoint: Vector2):
var coords = self.local_to_map(collisionpoint)
var herocoords = self.local_to_map(hero.position)
var x_start = min(herocoords.x, coords.x)
var x_end = max(herocoords.x, coords.x)
var y_start = min(herocoords.y, coords.y)
var y_end = max(herocoords.y, coords.y)
for x in range(x_start,x_end + 1):
for y in range(y_start,y_end + 1):
if Vector2i(x,y) in invisibletiles:
invisibletiles.erase(Vector2i(x,y))
notify_runtime_tile_data_update()
func _ready():
pass
func _use_tile_data_runtime_update(coords):
if coords in invisibletiles: return true
else: return false
func _tile_data_runtime_update(coords, tile_data):
if coords in invisibletiles:
tile_data.modulate.a = 0Tomkun Where do you populate the invisibletiles array? At the start it needs to contain the coords of all cells in the map, because you start with all of them being invisible.
Umm you also don't need to do that check in _tile_data_runtime_update(). That's already handled in _use_tile_data_runtime_update(). Everything that passes that check needs its alpha set to 0.
xyz
Oh yeah, that's a leftover from when I didn't realise I didn't have to reset the modulation back to 1.
I populate the array from the same script I use to generate the dungeon. It's very simple:
func HideCells():
for cell in hiddenfloorlayer.get_used_cells():
hiddenfloorlayer.invisibletiles.push_back(cell)Tomkun Put some prints in the reveal_tile to see if anything actually gets erased. Always put some prints when the code is not behaving as expected.
I'd suggest starting with a simpler version where only the tile the player is on gets revealed. That way you can be sure that tilemap update is actually working. Then proceed to implement a more complex algorithm for deciding which tiles to reveal.
xyz
I can get the tiles to reveal themselves reliably. That's not the issue any longer. What I want to improve is the algorithm I'm using to choose which tiles to reveal. At the moment it's revealing all tiles in a straight line, but I'd prefer a cone, or even a complete 360, but from what I can understand, raycasting wouldn't be an efficient way to do that.
Tomkun Well that's another problem altogether.
Use a cone (or a circle) collider on the player to get all cells in range and then test each for visibility via a raycast. Worry about efficiency when you profile it. I doubt it will be an issue especially since you don't need to do it every frame. For cone you need to check only when player changed the movement direction or entered another tile. For a circle it's even less, you need to check only when player enters another tile.
Is there a signal or something to use to make it fire when a new tile is entered, or does the _use_tile_data_runtime_update(coords) function take care of that?
Oh, never mind, just realised I can do it with physics layers.
Tomkun You can use some collision but it's simpler to just check player's position. You always know at which cell the player is (via local_to_map()). Just maintain that value, get it every frame. If there's a difference compared to what is stored from the previous frame, the change happened.
I'm having so much trouble with it though. Sometimes it doesn't detect walls, sometimes it does but local_to_map() converts to the wrong cell. It's being a royal pain to figure out.
I think what is happening is the if the raycast collides with a tile to the left or top, using local_to_map() rounds up so it gets detected as either one cell too low or to the right.
xyz
I am already casting from center to center. That's the default setting of map_to_local().
I am getting collisions detected on tiles that aren't even between the player and the target tile. Unfortunately, I can't find any pattern to it yet, so I can't figure out why it's happening.
func reveal_tile(coords):
#print (coords)
var radius = 1
var x_start = coords.x - radius
var x_end = coords.x + radius + 1
var y_start = coords.y - radius
var y_end = coords.y + radius + 1
print ("Hero Coords: ",coords)
for x in range(x_start,x_end):
for y in range(y_start,y_end):
print ("Target Cell: ",Vector2i(x,y))
if Vector2i(x,y) in invisibletiles:
#tile to hero
#raycast.global_position = self.map_to_local(Vector2i(x,y))
#raycast.target_position = self.map_to_local(coords) - raycast.global_position
#hero to tile
raycast.global_position = self.map_to_local(coords)
raycast.target_position = self.map_to_local(Vector2i(x,y)) - raycast.global_position
#print (BetterTerrain.get_cell(self,raycast.get_collision_point()))
#print (Vector2i(x,y))
#print (self.local_to_map(raycast.get_collision_point()))
#print (raycast.get_collision_normal())
if !raycast.is_colliding() || Vector2i(x,y) == self.local_to_map(raycast.get_collision_point()):
print("Clear")
invisibletiles.erase(Vector2i(x,y))
notify_runtime_tile_data_update()
else:
#print ("Hero Coords: ",coords)
#print ("Target Cell: ",Vector2i(x,y))
print ("Collided : ",self.local_to_map(raycast.get_collision_point()))
else:
print ("Already Revealed")Right, I have all the raycasting worked out and removing the correct tiles from the list, but still occasionally some tiles won't update. Seems to happen most when you enter a relatively large room (but not always). Once this has happened, they will never update again until the map is regenerated.
Is it possible for _tile_data_runtime_update() to get choked up and not update the tiles?
Okay, I really need some more help.
As far as I can tell, my code is working just fine.
The raycasts are returning the cells that are in line-of-sight of the hero and removing them from the invisibletiles array.
I then call notify_runtime_tile_data_update() which triggers the update and the tile appears.
So far, so good.
However, I have noticed that occasionally a tile will not appear, even though it has been removed from the array.
I have created a helper function to troubleshoot:
func double_check(target : Vector2) -> void:
var cell = self.local_to_map(target)
print(cell)
if cell in invisibletiles:
print ("invisible -> visible")
invisibletiles.erase(cell)
notify_runtime_tile_data_update()
else:
print("visible -> invisible")
invisibletiles.append(cell)
notify_runtime_tile_data_update()This allows me to trigger the tiles visibility at will, however those tiles will still not become visible.
Unless... I hide another tile somewhere else and then suddenly it will start to work! Although now the tile that I 'turned off' will no longer turn back on...
Now, I don't understand this behaviour at all. If I understand correctly, the function:
func _tile_data_runtime_update(_coords, tile_data):
tile_data.modulate.a = 0Is making the tiles invisible, so if this function does not run on the tile, it should be visible by default, but it isn't. The tile has been removed from the array and therefore this function is not being called on it.