Bullet hole decals not rotating properly when surface is level/vertically flat

DoubleA

For whatever reason bullet holes created when firing weapons do not rotate properly when the surface fired at is perfectly flat or level.

My code for bullet hole creation (r is the hitscan raycast node):

var b = bullethole.instantiate()
r.get_collider().add_child(b)
b.global_transform.origin = r.get_collision_point()
b.look_at(r.get_collision_point() + r.get_collision_normal())

Lethn

It's because you're adding the decal as a child of the collider, I've run into this problem before as well, I'm trying to remember but I think if you add it to the root or set it as TopLevel it should work, it's copying the scale of the collided object which is why it turns out so weird, you don't need to add the decal to the collider anymore for the decal to work properly, that's old code.

DoubleA

Lethn The size isn't the issue, the rotation is. When I call the look_at() function when creating a decal on a level surface, the decal doesn't rotate to face upwards properly, instead facing forwards on the Z axis.

Lethn

		if SingleRaycast.is_colliding() == true:
			
			FRPistolAnimationPlayer.play("recoilFRPistol")
			var plasmaBulletHoleChild = plasmaBulletHole.instantiate()
			get_tree().get_root().add_child(plasmaBulletHoleChild)
			plasmaBulletHoleChild.global_transform.origin = SingleRaycast.get_collision_point()
			
			FRPistolMuzzleFlash.emitting = true
			FRPistolMuzzleFlash2.emitting = true
			FRPistolMuzzleFlash3.emitting = true
			muzzleFlashLight.visible = true
			
			
			SingleRaycast.transform.origin = Vector3(randf_range(-0.8, 0.8), randf_range(-0.8, 0.8), -0.032)
			
			if SingleRaycast.get_collision_normal() == surfaceDirectionUp:
				plasmaBulletHoleChild.look_at(SingleRaycast.get_collision_point() + SingleRaycast.get_collision_normal(), Vector3.RIGHT)
			elif SingleRaycast.get_collision_normal() == surfaceDirectionDown:
				plasmaBulletHoleChild.look_at(SingleRaycast.get_collision_point() + SingleRaycast.get_collision_normal(), Vector3.RIGHT)
			else:
				plasmaBulletHoleChild.look_at(SingleRaycast.get_collision_point() + SingleRaycast.get_collision_normal(), Vector3.UP)
			
			canFire = false
			FireRateTimer.start()

There were extra rotations that were posted up in the youtube comments I saw which I forgot about, my bad, this is what I ended up with for my controller, still wouldn't recommend adding as a child I think that causes problems with the aforementioned scaling, you don't want your decal node being stretched and if you aren't using a decal node, you absolutely should.

DoubleA

Lethn After a bit of tweaking, I got a working function! Here it is:

func create_bullethole(r):
	var b = bullethole.instantiate()
	r.get_collider().add_child(b)
	b.global_transform.origin = r.get_collision_point()
	if r.get_collision_normal() == Vector3(0,1,0):
		b.look_at(r.get_collision_point() + r.get_collision_normal(), Vector3.RIGHT)
	elif r.get_collision_normal() == Vector3(0,-1,0):
		b.look_at(r.get_collision_point() + r.get_collision_normal(), Vector3.RIGHT)
	else:
		b.look_at(r.get_collision_point() + r.get_collision_normal())

(variable r represents the hitscan raycast)

I did end up leaving the bullet holes as children of the collided object because in my game bullet holes are also created on physics bodies able to move, and making them children of the root caused the hole to not stay on the object.