T

TwoFox

I'm trying to write a module using tree-sitter with some custom grammars. Here's a minimal example that works outside of Godot:

/* main.cpp */
#include <tree_sitter/api.h>

int main() {
  TSParser* p = ts_parser_new();
  return 0;
}

# SConstruct
env = Environment()

env.Append(LIBPATH="/home/teehee/git/tree-sitter")
env.Append(LIBS="tree-sitter")

env.Program("out", "main.cpp")

For the test in Godot, I made a trivial module and pasted in the above code:

/* printer_of_2s.cpp */
#include "printer_of_2s.h"
#include <tree_sitter/api.h>

int tt_fn() {
  TSParser* p = ts_parser_new();
  return 0;
}


void PrinterOf2s::print_two() {
  print_line(two);
}

void PrinterOf2s::_bind_methods() {
  ClassDB::bind_method(D_METHOD("print_two"), &PrinterOf2s::print_two);
}


PrinterOf2s::PrinterOf2s() {
  two = 2;
}

# SCsub
Import('env')

menv = env.Clone()
menv.add_source_files(env.modules_sources, "*.cpp")
menv.Append(CPPPATH="/home/teehee/git/tree-sitter/lib/include")

env.Append(LIBPATH="/home/teehee/git/tree-sitter")
env.Append(LIBS="tree-sitter")

After compiling with scons p=windows custom_modules=~/godot/modules/ -j 3 (I'm using WSL), I get a linker error:

/usr/bin/x86_64-w64-mingw32-ld: modules/libmodule_simple.windows.editor.x86_64.a(printer_of_2s.windows.editor.x86_64.o):printer_of_2s.:(.text+0x125): undefined reference to `ts_parser_new'

I know that the function is defined, because otherwise the first program wouldn't compile. I also know that scons can find the library, because that would give me a different error. I'm not sure what I could be doing differently.

DaveTheCoder Thank you for the link. I found a solution in one of the issues, but I still don't understand that constructor.

rayner9718 Try moving the node with your fall zone above the node with your character. It could be that the signal is being emitted before the function connects to it.

TwoFox Ah, silly me, I just restated your question. The reason why it doesn't work is that pure Controls don't
tile their children. You have to code that behaviour yourself

I could help out with writing and a bit of code

When I was in school, I spent a lot of time reading about lectureship and experimenting with techniques to make my learning more efficient (cause I hated school and wanted to spend as little time studying as possible). What I came up with is a 3-step process. Ideally, you'd have both the docs and a solution on-hand.

If not, then you can go back to the scientific method: formulate a theory, test that theory and nothing else, formulate a new theory, repeat. In the context of game dev, this would usually mean putting print statements everywhere or watching vars in the debugger. It helps to have some sort of automated testing system for your game. This method is more general but also slower.

Anyway, if I have ideal conditions, then here's what I do:

1. Solve the problem, while following the solution to a T.
2. Solve the problem, only looking at the solution for hints.
3. Solve the problem on my own without any help.
4. If at any point, you see something you don't understand, look it up in the docs.

Also, spam asserts everywhere. Every time you make any assumption about your code, assert. You have no idea how often I've had things crash and burn because I've had values that weren't what I've thought. In the same vein, only develop one feature at a time and pay close attention to your APIs, e.g. Instead of trying to make 'enemy AI', make a path finding algorithm first, and then a state machine that responds to the path finding. And lastly, regularly rebuild small portions of your game from scratch. You'll get better over time, and better code is easier to maintain.

xyz I completely forgot about styleboxes and overrides. Thank you

xyz That should be impossible. Every character that gets created is added to _chars. And that part of the function is called only if _chars.get() returns non-null. Also, the full error says:

Invalid set index 'texture' (on base: 'Panel') with value of type 'CompressedTexture2D'

even if I use x.get_child(0), instead of x.get_node(), so it looks to me like the game can find the right node.

I'm working on a HUD for a visual novel. I have a cache for characters that have been shown so far (independent of the characters actually on-screen), a function to hide them and another one to show them, move them around, change expressions, etc.

func show_char(who: String, model: String, lock_chars := true) -> void:
	assert(who != "")
	assert(who.is_valid_filename(), "'%s'" % who)

	# Default to base_model if called with an empty string
	if model == "":
		model = base_model
	assert(model.is_valid_filename(), "'%s'" % model)

	# Determine side
	var side: Container
	if _next_side:
		side = %Characters/Right
	else:
		side = %Characters/Left
	assert(side != null)

	# If this character has been shown before, simply reuse the node
	var x: AspectRatioContainer = _chars.get(who)
	if x:
		print(x.get_node("model"))
		var model = char_path + who + "/" + model
		x.get_node("%model").texture = load(model)
		# If the character is shown on the correct side or lock_chars
		# is true, do nothing
		if x.get_parent() == side or lock_chars:
			return
		# If the character is shown on a different side, hide them
		if x.get_parent() != null:
			x.get_parent().remove_child(x)
		# Show character on the correct side
		side.add_child(x)
		x.set_owner(side)
		# Toggle side
		_next_side = not _next_side
		return

	# Character not shown before. Build a new branch
	assert(_chars.get(who) == null, 
			"Tried to create an existing character '%s'" % who)
	# Prepare the branch
	var img := StyleBoxTexture.new()
	var img_panel := Panel.new()
	var img_container := AspectRatioContainer.new()
	# Load texture
	model = char_path + who + "/" + model
	assert(ResourceLoader.exists(model),"%s" % model)
	img.texture = load(model)
	# Adjust min size
	img_container.set_custom_minimum_size(img.texture.get_size())
	# Build the new panel
	img_panel.add_theme_stylebox_override("panel", img)
	img_panel.set_name("model")
	img_panel.set_unique_name_in_owner(true)
	# Add panel to container
	img_container.add_child(img_panel)
	img_panel.set_owner(img_container)
	# Name container
	img_container.set_name(who)
	img_container.set_unique_name_in_owner(true)
	# Record it in _chars
	_chars[who] = img_container
	# Add it to SceneTree
	side.add_child(img_container)
	img_container.set_owner(side)
	# Toggle side
	_next_side = not _next_side


func hide_char(who: String) -> void:
	assert(_chars.get(who) != null, "%s" % who)
	assert(_chars.get(who).get_parent() != null, "%s" % who)

	# Search CharacterRow for the given character and hide them.
	var x: AspectRatioContainer = _chars.get(who)
	x.get_parent().remove_child(x)
	x.set_owner(null)

The character row is just a bunch of HBoxContainers inside of a MarginContainer.

The problem comes from hiding and then showing the same character model. The first call to load(), in the 2nd part of show_char(), returns a Texture2D, and life is good. The 2nd call then tries to load the same image but returns a CompressedTexture2D, which raises an Invalid set index error. How can I force load() to always return a Texture2D?