Encrypted save file from godot 3 doesn't work in godot 4.

belgian_street_lamp

belgian_street_lamp but updating the godot 3 version seems to be the best choice so far :/

DaveTheCoder

In the Godot 4 version of the game, you could detect whether a user is trying to load an incompatible file created with Godot 3. Then display a message saying that the user needs to use the updated Godot 3 version of the game to convert the file.

A better solution would be to delay publishing the Godot 4 version until you figure out how to load the Godot 3 files in Godot 4. But you've suggested that's not possible.

belgian_street_lamp

DaveTheCoder Or i will just release a new app called version converter, and if a user gets this error they will need to just install the app which will convert the save file to configfile and then it could be opened in godot 4 version.

DaveTheCoder

Apps must target Android 13 (API level 33) or higher

That was fixed in Godot 3.5.3.
[3.x] Bump the target SDK version to 33 (Android 13) #75205

belgian_street_lamp

belgian_street_lamp or I could delay, what is the better option?

DaveTheCoder

Delaying seems easier for the users.

belgian_street_lamp

DaveTheCoder Ok, I just hope someone will write a converter soon.

DaveTheCoder

belgian_street_lamp I just hope someone will write a converter soon.

No promises, but I might spend some time on this.

void store_var ( Variant value, bool full_objects=false )

What kinds of values do you pass as the first parameter (int, float, etc.)?
Do you pass any objects as the first parameter, with the second parameter passed as true?
Which of these do you use?
open()
open_compressed()
open_encrypted()
open_encrypted_with_pass()

DaveTheCoder

Using the decryption code posted above, I was able to read, in Godot 4, an encrypted file created in Godot 3 that uses store_var().

So the encryption issue is almost solved. One remaining detail is that I don't understand this comment:
# md5, you can check if decrypted data md5 hash match to verify it's ok
That implies that verifying that the data is not corrupt requires an additional check, and I couldn't figure out how to do that.

The remaining problem is the enum renumbering issue that I linked above. These data types are unaffected: bool, int, float, String and Vector2. The problem only occurs if you use store_var() for other data types.

belgian_street_lamp

DaveTheCoder you mean godot 3, right?

belgian_street_lamp

DaveTheCoder I unfortunately use a dictionary, open_encrypted_with_pass, no objects

DaveTheCoder

belgian_street_lamp you mean godot 3, right?

Yes. I edited the post and fixed that.

DaveTheCoder

belgian_street_lamp I unfortunately use a dictionary, open_encrypted_with_pass, no objects

Does your game you use one store_var only, for a Dictionary? What kind of values are in the Dictionary?

I'll attempt to set up a test file similar to yours, so that I can experiment with reading it in Godot 4.

belgian_street_lamp

{ "version": ["0.1.5.", "alfa"], "cinemalvls": [1, 1, 1], "hatsbought": [0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0], "charactersbought": { "c1": true, "c2": false, "c3": false, "c4": false, "c5": false, "c6": false, "c7": false, "c8": false }, "coins": 0, "vidcoins": 0, "keys": 0, "keylist": [1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1], "settings": [0, 0, false, 8, 1, true, 1, 1, "left"], "currentlevel": "level1", "currentfolder": "levels", "firstversion": ["", false], "jumpspeed": [1, 1], "screensize": (1, 1), "currenthat": "empty", "character": "c1", "hateq": "empty", "sword": "wooden", "maxhealth": [3], "maxair": [10], "eventmoney": [0, 0, 0], "username": "user", "tutorial": 0, "unlockedlevels": ["tutorial1", "level1"] }

DaveTheCoder

I thought I had this solved.

I created Godot 4 GDScript functions that successfully read files created in Godot 3 using store_var(), both unencrypted and encrypted. They work correctly using this simple test data:

const I: int = 42
const F: float = 7.5
const B: bool = true
const S: String = "hello"
const V: Vector2 = Vector2(1.1, 2.2)
const A: Array = [3, 4]
const D: Dictionary = {"a": 15, "b": 30}

But when I include in the test the complex Dictionary you posted, that fails. It gets read as a Dictionary, but the keys/values are messed up.

The apparent problem is that my enum conversion needs to descend recursively for Arrays and Dictionaries, which makes sense now that I think about it.

belgian_street_lamp

🙁 I wish i could help (im not smart enough)

DaveTheCoder

belgian_street_lamp I wish i could help

You already helped by providing that decryption code.

I'm depending on you to do extensive testing if/when I finish this. 😉

award

Crazy idea, throwing it out there:

Create a website with your Godot 3 engine version on it. Create a REST API endpoint which receives the encrypted file as part of an API request, decrypts it, and returns it in an intermediary format. Probably JSON would be easiest.

The Godot v4 app then, if it can't decrypt the cfg file, makes a PUT request to the endpoint, receives back the JSON, and then uses that to make the new v4 config file to overwrite the old one with.

This would be a lot of work to implement, but I thought I'd mention it just in case nothing else works out.

DaveTheCoder

I've solved the encryption problem. One detail remaining is to figure out how to detect whether a file was encrypted in Godot 3 without depending on getting a ERR_FILE_CORRUPT error from FileAccess.open_encrypted_with_pass(), but that's mainly cosmetic.

I'm working on the other problem, that the enum Variant.Type values were changed from Godot 3 to Godot 4. I have a tentative solution, but I need to finish coding and testing it.

Ideally this should be packaged as a GDExtension plugin (or included in the engine), but for now it will be a GDScript plugin.

DaveTheCoder

Major breakthrough. I finally got nested Arrays and Dictionaries working. I felt like I was losing my mind.

I need to check that all the other data types work. Then it's just a matter of cleaning up and packaging it as a plugin.

« Previous Page Next Page »