What's the Godot 4 equivalent of extents?

DaveTheCoder

My guess is that when using size instead of extents, you may have to shift the reference point. Instead of measuring from the rectangle's center, measure from the top left corner.

Also, with size, you wouldn't divide or multiple by two.

xyz

selectRectangle.size = (dragEnd - dragStart).abs()

Lethn

Yeah, this is the problem I've been running into with the selection box collision shape generally, how do I change the pivot point or is it not possible? I did see some dicussion on github about this and apparently it's not but these were old posts.

Edit: Oh! Thanks @xyz

Lethn

Invalid set index 'size' (on base: 'Array[Dictionary]') with value of type 'Vector2'.

Lethn

Now why is it trying to claim that the size is an array?

xyz

Lethn It actually says that selectRectangle is an array.

Lethn

Lemme poke at this some more.

Lethn

https://godotengine.org/qa/3458/collisionshape2d-shape-being-set-correctly-gdscript-code

Weird, thought I'd come across something in old posts but nope, I'm drawing blanks, I've barely seen any reference to this particular error online.

Lethn

extends Node2D

var isDragging = false
var selectedUnits = []
var dragStart = Vector2()
var selectedRectangle = RectangleShape2D.new()

func _unhandled_input(event):
	if event is InputEventMouseButton and event.button_index == MOUSE_BUTTON_LEFT:
		if event.is_pressed():
			if selectedUnits.size() == 0:
				isDragging = true
				dragStart = event.position
		elif isDragging == true:
			isDragging = false
			queue_redraw()
			var dragEnd = event.position
			selectedRectangle.size = (dragEnd - dragStart).abs()
			
			var space = get_world_2d().direct_space_state
			var query = PhysicsShapeQueryParameters2D.new()
			query.set_shape(selectedRectangle)
			query.transform = Transform2D (0, (dragEnd + dragStart) / 2)
			selectedRectangle = space.intersect_shape(query)
			
	if event is InputEventMouseMotion and isDragging == true:
		queue_redraw()
		
func _draw():
	if isDragging == true:
		draw_rect(Rect2 (dragStart, get_global_mouse_position() - dragStart), Color.DARK_GREEN, false)

Posting up full code just to make sure I'm not doing something daft.

xyz

Lethn According to the reference PhysicsDirectSpaceState2D::intersect_shape returns an array of dictionaries, which you, for some reason assigned to selectedRectangle.

Lethn

I'm just following along the tutorial lol, I don't know if it's that Godot 4 maybe broke something or what, I do know the physics query behaviour did go through some drastic changes lately.

8:10 for relevant info.

Lethn

Lethn Oh for crying out loud, you're right, I know exactly what I've done, I'm tired and I've mixed up the variable naming LOL.


extends Node2D

var isDragging = false
var selectedUnits = []
var dragStart = Vector2()
var selectedRectangle = RectangleShape2D.new()

func _unhandled_input(event):
	if event is InputEventMouseButton and event.button_index == MOUSE_BUTTON_LEFT:
		if event.is_pressed():
			if selectedUnits.size() == 0:
				isDragging = true
				dragStart = event.position
			else:
				selectedUnits = []
		
		elif isDragging == true:
			isDragging = false
			queue_redraw()
			var dragEnd = event.position
			selectedRectangle.size = (dragEnd - dragStart).abs()
			
			var space = get_world_2d().direct_space_state
			var query = PhysicsShapeQueryParameters2D.new()
			query.set_shape(selectedRectangle)
			query.transform = Transform2D (0, (dragEnd + dragStart) / 2)
			selectedUnits = space.intersect_shape(query)
			print(selectedUnits)
			
			for selection in selectedUnits:
				print(selection)
			
	if event is InputEventMouseMotion and isDragging == true:
		queue_redraw()
		
func _draw():
	if isDragging == true:
		draw_rect(Rect2 (dragStart, get_global_mouse_position() - dragStart), Color.DARK_GREEN, false)

Instantly fixed now, thanks 😃 classic, was wondering what the hell was going on, just need to finish the tutorial now, that line you gave me is what did the trick for the initial problems, will post updated code when finished just for the sake of it being completed because this is a good tutorial.

Edit: Just needed to tweak the code a tiny bit to finish it off, will need to add other mechanics in to make it more usable.

Lethn

I'm enjoying a lot how accurate this selection box is, bet it will be great for all sorts of game types.

Lethn

Just an extra bonus for anyone that stumbles on this thread, gave it a bit of an extra feature by adding some selection by type using simple variable checks, this could very easily be adapted so that you can drag select only certain unit types or objects among other things, really liking this now I'm used to the code.

extends Node2D

var isDragging = false
var selectedUnits = []
var dragStart = Vector2()
var selectedRectangle = RectangleShape2D.new()

func _unhandled_input(event):
	if event is InputEventMouseButton and event.button_index == MOUSE_BUTTON_LEFT:
		if event.is_pressed():
			if selectedUnits.size() == 0:
				isDragging = true
				dragStart = event.position
			else:
				for selection in selectedUnits:
					selection.collider.DisableSelection()
					selectedUnits = []
		
		elif isDragging == true:
			isDragging = false
			queue_redraw()
			var dragEnd = event.position
			selectedRectangle.size = (dragEnd - dragStart).abs()
			
			var space = get_world_2d().direct_space_state
			var query = PhysicsShapeQueryParameters2D.new()
			query.set_shape(selectedRectangle)
			query.transform = Transform2D (0, (dragEnd + dragStart) / 2)
			selectedUnits = space.intersect_shape(query)
			for selection in selectedUnits:
				if selection.collider.player == 1:
					selection.collider.EnableSelection()
				if selection.collider.player == 2:
					selection.collider.DisableSelection()
					selectedUnits.erase(selection)
			
	if event is InputEventMouseMotion and isDragging == true:
		queue_redraw()
		
func _draw():
	if isDragging == true:
		draw_rect(Rect2 (dragStart, get_global_mouse_position() - dragStart), Color.DARK_GREEN, true)

Lethn

extends Node2D

var isDragging = false
var selectedUnits = []
var dragStart = Vector2()
var selectedRectangle = RectangleShape2D.new()

func _unhandled_input(event):
	if event is InputEventMouseButton and event.button_index == MOUSE_BUTTON_LEFT:
		
		if event.is_pressed():
				isDragging = true
				dragStart = event.position
				
				for selection in selectedUnits:
					var selectionCollision = selection.collider
					if selectionCollision.is_in_group("Selectable"):
						selectionCollision.DisableSelection()
						selectedUnits = []
		
		elif isDragging == true:
			isDragging = false
			queue_redraw()
			var dragEnd = event.position
			selectedRectangle.size = (dragEnd - dragStart).abs()
			
			var space = get_world_2d().direct_space_state
			var query = PhysicsShapeQueryParameters2D.new()
			query.set_shape(selectedRectangle)
			query.transform = Transform2D (0, (dragEnd + dragStart) / 2)
			selectedUnits = space.intersect_shape(query)
			
			for selection in selectedUnits:
				var selectionCollision = selection.collider
				if selectionCollision.is_in_group("Selectable"):
					selectionCollision.EnableSelection()
			
					
	if event is InputEventMouseMotion and isDragging == true:
		queue_redraw()
		
func _draw():
	if isDragging == true:
		draw_rect(Rect2 (dragStart, get_global_mouse_position() - dragStart), Color.DARK_GREEN, false)

Here's a more C&C style selection box which is what I was aiming for, I didn't realise the if statement at the beginning was causing so many problems for me, it should all be fine and work as you'd expect now, not sure what KidsCanCode was aiming for with his version lol.

Snayff

@Lethn thank you so much for sharing the updated code, and for sharing your continued improvements. Legend.