Stopped Moving Left

OverlordMikey

I am making a simple game where you catch coins as they fall and for some reason my character will sometimes freeze up when moving left. Test suggest the problem sorts itself out when jumping, but basically the character will move left for a brief moment and then stop moving. It wasn't doing this before so I have no idea what's up, it started when I began working on the coins (which are still a WIP). Also note that I am using Godot_v4.5.2-stable. It's quicker to show you the whole project so here:

gold-drop-game.zip

163kB

Side Note: I'm just starting out with Godot and this game is an experiment to teach me so I am VERY open to suggestions about making my code neater and more efficient. I get that everyone has different ways of doing things so I would love to hear suggestions from as many people as possible.

Thanks in advance!

DaveTheCoder

A possible fix is to change velocity.y only when the player is jumping. In player_one.gd / _physics_process():

if not is_on_floor():
    apply_gravity(delta)

OverlordMikey love to hear suggestions

I highly recommend static typing:
https://docs.godotengine.org/en/4.5/tutorials/scripting/gdscript/static_typing.html

Regarding efficiency, avoid using $JumpTimer or get_node("JumpTimer") in code that's executed frequently:
$JumpTimer.start(1.5)
Instead, save the node reference in a variable:

# at top of script before the functions:
@onready var jump_timer: Timer = $JumpTimer

# in get_input():
jump_timer.start(1.5)

The same applies to $AnimatedSprite2D.

When testing a boolean, you don't need to compare it with true or false.
These are equivalent:
if Input.is_action_just_pressed("jump") and is_on_floor() and can_jump == true:
if Input.is_action_just_pressed("jump") and is_on_floor() and can_jump:
Instead of my_bool == false, you can use not my_bool or !my_bool.

OverlordMikey

DaveTheCoder

I'll try that and see if it works, update you if it does.

Also I actually knew about static typing but completely "forgot" about static typing! Ha, silly Mikey!
As for the rest of yer advice. I'll try it out! Thank you!

OverlordMikey

DaveTheCoder It worked! Also I tried some of yer suggestions and they work wonders.

I can't figure out how to mark yer answer as the best answer. I haven't used the forums that much. What do I press?

OverlordMikey

DaveTheCoder A possible fix is to change velocity.y only when the player is jumping. In player_one.gd / _physics_process():

if not is_on_floor():
apply_gravity(delta)

This in fact did not work, back to the drawing board. (although it happens less often so I think we're on the right path)

DaveTheCoder

That's strange. It worked when I tested it.

My guess was that changing velocity.y when not jumping resulted in move_and_collide() trying to move mostly in a vertical direction. But if that's true, then why is only the left movement affected, and not the right movement?

OverlordMikey I can't figure out how to mark yer answer as the best answer.

It's one of the choices in the ... menu below the reply. Whether that choice is available seems to depend on the original post's tags. But since my reply didn't solve your problem, it probably shouldn't be marked as "best answer".