A better way to iterate through Array in a loop?

Rainfollower

I have an Array of values, and I need to cycle through it: next, next, next, and when it is the last element, go back to first.

I thought I found the most elegant solution with Array.get() because it does not break the execution:

currentCastleID += 1
if not castle_lists.keys().get(currentCastleID):
	currentCastleID = 0

But it generates the error: Index p_index = 8 is out of bounds (p_instance->size() = 8)

Of course I could check that element's index is equal to the Array size... But this feels not very elegant.

Is there a prettier way, maybe? The problems seems very basic, must be encountered a zillion times already...

Dad3353

Rainfollower

Before incrementing, check that the ID is not already the last one..? If it is, reset to ID 0.

DaveTheCoder

Use the modulus operator (%) when incrementing the array index.
https://www.geeksforgeeks.org/computer-science-fundamentals/modulus-operator-in-programming/

currentCastleID = (currentCastleID + 1) % castle_lists.keys().size()

You don't need the "if", if its only purpose is checking that the array index is in bounds. The modulus operator guarantees that.

Rainfollower

DaveTheCoder oh that's beautiful! Thanks ))

fire7side

You could use a recursive function also:

func doSomething():
     for i=0; i<castle_lists.keys().size(); i++:
          #check for whatever
          pass
     doSomething()

You'd need a break in there someplace to get out of an infinite loop same as the rest of this. If this is off subject or the wrong language, just ignore me.