Solium - personal research and development

kuligs2

fire7side that is not the root problem im having. I do know how to blend animations, but the problem is that for some reason, going from one anim to another resets root motion velocity to zero while other case does not.

fire7side

It sounds like it has something to do with the root bone and I haven't used it. If I get an animation looking half decent, I'm happy.

kuligs2

fire7side At first glance from memory, the root bone positions were synced and movement over the frames was linear. I havent had much time to investigate more. Same principle was for running animation, and switching between walk and run works as expected - no velocity reset to 0.0.

kuligs2

Doing some investigation:

Noticing that walk animation and run animation, root bone Y position is linear like straight line at an angle.

But the walk_start has like this:

That horizontal line before 1st frame and after frame 5 could be the culprit.

Now im remembering that the walk and run has curve modifier "cycles"

Fixed:

Lets test this out in game:
Nope, it still upon switch from walk_start animation to walk animation, drops velocity to zero.

I still cant figure out what is resetting my velocity. code for all state switches is the same.

walk_start.gd

extends StateInterface

class_name WalkStartState

var character: Player
var is_blocking:bool = false

func enter(_prev_state: String = "")-> void:
	character = state_machine.owner
	character.animation_player.animation_finished.connect(on_animation_finished)
	character.animation_player.play("Walk_start")
	character.is_root_motion = true
	is_blocking = true
	
func exit() -> void:
	if character.animation_player.animation_finished.is_connected(on_animation_finished):
		character.animation_player.animation_finished.disconnect(on_animation_finished)
		
func physics_update(_delta: float) -> void:
	if character.direction:
		var up := Vector3.UP
		# For root motion
		var forward : Vector3 = character.direction # Check this value if its in correct way
		var right := up.cross(forward).normalized()
		var corrected_up := forward.cross(right).normalized()
		var target_basis := Basis(right, corrected_up, forward).orthonormalized() 
		var a = character.transform.basis.get_rotation_quaternion()
		var b = target_basis.get_rotation_quaternion()
		var c = a.slerp(b,0.3)
		character.transform.basis = Basis(c).orthonormalized()

		character.velocity = character.get_quaternion() * character.animation_player.get_root_motion_position() / _delta
		character.set_quaternion(character.get_quaternion() * character.animation_player.get_root_motion_rotation())
	#else:
		#state_machine.change_state("idle")

	if not character.is_on_floor():
		state_machine.change_state("Jump_midair_90")
		return
		

	if not is_blocking:
		_decide_next_state()
	
	character.move_and_slide()
	
	
func on_animation_finished(_animation_name):
	character.animation_player.animation_finished.disconnect(on_animation_finished)
	is_blocking = false
	
func _decide_next_state():
	if Input.get_vector("k_left", "k_right", "k_forward", "k_backward"):
		if Input.is_action_pressed("k_sprint"):
			state_machine.change_state("Run_16")
			return
		if Input.is_action_pressed("k_crouch"):
			state_machine.change_state("Crouch_walk_32")
			return
		state_machine.change_state("walk")
		return
		
	if Input.is_action_just_pressed("k_jump") and character.is_on_floor():
		state_machine.change_state("Jump_ascend_9")
		return
		
	if Input.is_action_pressed("k_crouch"):
		state_machine.change_state("Crouch_90")
		return
			
	state_machine.change_state("walk_stop")
	return

walk.gd

extends StateInterface

class_name WalkState

var character: Player

func enter(_prev_state: String = "")-> void:
	character = state_machine.owner
	character.animation_player.play("Walk_32")
	character.is_root_motion = true

func physics_update(_delta: float) -> void:
	if character.direction:
		var up := Vector3.UP
		# For root motion
		var forward : Vector3 = character.direction # Check this value if its in correct way
		var right := up.cross(forward).normalized()
		var corrected_up := forward.cross(right).normalized()
		var target_basis := Basis(right, corrected_up, forward).orthonormalized() 
		var a = character.transform.basis.get_rotation_quaternion()
		var b = target_basis.get_rotation_quaternion()
		var c = a.slerp(b,0.3)
		character.transform.basis = Basis(c).orthonormalized()

		character.velocity = character.get_quaternion() * character.animation_player.get_root_motion_position() / _delta
		character.set_quaternion(character.get_quaternion() * character.animation_player.get_root_motion_rotation())
	else:
		state_machine.change_state("walk_stop")

	if not character.is_on_floor():
		state_machine.change_state("Jump_midair_90")
		return
		
	character.move_and_slide()

func handle_input(_event: InputEvent) -> void:
	if Input.is_action_just_pressed("k_jump") and character.is_on_floor():
		state_machine.change_state("Jump_ascend_9")
		return
		
	if Input.is_action_pressed("k_sprint"):
		state_machine.change_state("Run_16")
		return
		
	if Input.is_action_pressed("k_crouch"):
		state_machine.change_state("Crouch_walk_32")
		return

run.gd

extends StateInterface

class_name RunState

var character: Player

func enter(_prev_state: String = "")-> void:
	character = state_machine.owner
	character.animation_player.play("Run_16")
	character.is_root_motion = true

func physics_update(_delta: float) -> void:
	if character.direction:
		var up := Vector3.UP
		# For root motion
		var forward : Vector3 = character.direction # Check this value if its in correct way
		var right := up.cross(forward).normalized()
		var corrected_up := forward.cross(right).normalized()
		var target_basis := Basis(right, corrected_up, forward).orthonormalized() 
		var a = character.transform.basis.get_rotation_quaternion()
		var b = target_basis.get_rotation_quaternion()
		var c = a.slerp(b,0.3)
		character.transform.basis = Basis(c).orthonormalized()

		character.velocity = character.get_quaternion() * character.animation_player.get_root_motion_position() / _delta
		character.set_quaternion(character.get_quaternion() * character.animation_player.get_root_motion_rotation())
	else:
		state_machine.change_state("idle")

	if not character.is_on_floor():
		state_machine.change_state("Jump_midair_90")
		return
		
	character.move_and_slide()

func handle_input(_event: InputEvent) -> void:
	if Input.is_action_just_pressed("k_jump") and character.is_on_floor():
		state_machine.change_state("Jump_ascend_9")
		return
		
	if Input.is_action_just_released("k_sprint"):
		print("Sprint released")
		state_machine.change_state("walk")
		return
		
	if Input.is_action_pressed("k_crouch"):
		state_machine.change_state("Crouch_walk_32")
		return

Velocity continues if walk -> run
Velocity sets to zero if walk_start -> walk

fire7side

It looks like you can adjust the speed in the animation editor:
If you want the entire animation—including the root bone's translation—to play faster, adjust the playback speed directly.Via AnimationPlayer: Select your AnimationPlayer node, look at the top toolbar of the animation editor, and increase the Speed Scale (e.g., change 1.0 to 1.5).
Maybe that's what you are doing or you are doing something more sophisticated. I don't even get what that graph you are showing does.

kuligs2

fire7side please re-read few posts before this one, and watch the video and see what im dealing with. it has nothing to do with what youre saying.

fire7side

oh, nevermind.

kuligs2

I have ran out of ideas to try to test..

Maybe someone dealing with 3D animations can help me understand how to set up animations in blender? I dont use mixamo, it might be the problem but i dont want to be limited by bogus licences..

I have triple checked animations and they are linear. But in godot it resets to zero.. my hunch is that maybe.. maybe 4 frame animation is too short for godot to understand and calculate the root position so it defaults to zero.. so my question is what is the the shortest in terms of frames, animation you can use in godot?

kuligs2

So here is a picture of what is going on. Debug messages are printed in physics process.
It prints currents animation/state character velocity and root motion position.
As you can see that when i go from idle > walk_start > walk the velocity drops to 0.0 which creates this jitter that im trying to fix. And it just looks awful.
But when animation goes from walk > run the velocity ramps up and no slowdown.

All animations have blending of 0.2
Same thing happens of blend is set to 0.0.

State: jump_landed_9 Velocity: 0.000 RM: (0.0, 0.0, 0.0)
State: jump_landed_9 Velocity: 0.000 RM: (0.0, 0.0, 0.0)
State: jump_landed_9 Velocity: 0.000 RM: (0.0, 0.0, 0.0)
Changing state to: idle
State: idle Velocity: 0.000 RM: (0.0, 0.0, 0.0)
State: idle Velocity: 0.000 RM: (0.0, 0.0, 0.0)
State: idle Velocity: 0.000 RM: (0.0, 0.0, 0.0)
State: idle Velocity: 0.000 RM: (0.0, 0.0, 0.0)
State: idle Velocity: 0.000 RM: (0.0, 0.0, 0.0)
State: idle Velocity: 0.000 RM: (0.0, 0.0, 0.0)
State: idle Velocity: 0.000 RM: (0.0, 0.0, 0.0)
State: idle Velocity: 0.000 RM: (0.0, 0.0, 0.0)
State: idle Velocity: 0.000 RM: (0.0, 0.0, 0.0)
State: idle Velocity: 0.000 RM: (0.0, 0.0, 0.0)
State: idle Velocity: 0.000 RM: (0.0, 0.0, 0.0)
State: idle Velocity: 0.000 RM: (0.0, 0.0, 0.0)
State: idle Velocity: 0.000 RM: (0.0, 0.0, 0.0)
State: idle Velocity: 0.000 RM: (0.0, 0.0, 0.0)
State: idle Velocity: 0.000 RM: (0.0, 0.0, 0.0)
State: idle Velocity: 0.000 RM: (0.0, 0.0, 0.0)
Changing state to: walk_start
State: walk_start Velocity: 0.000 RM: (0.0, 0.0, 0.0)
State: walk_start Velocity: 0.000 RM: (0.0, 0.0, 0.0)
State: walk_start Velocity: 0.242 RM: (0.0, 0.0, 0.004698)
State: walk_start Velocity: 0.524 RM: (0.0, 0.0, 0.009396)
State: walk_start Velocity: 0.676 RM: (0.0, 0.0, 0.011664)
State: walk_start Velocity: 0.726 RM: (0.0, 0.0, 0.012312)
State: walk_start Velocity: 0.771 RM: (0.0, 0.0, 0.01296)
State: walk_start Velocity: 0.813 RM: (0.0, 0.0, 0.013609)
State: walk_start Velocity: 0.854 RM: (0.0, 0.0, 0.014257)
State: walk_start Velocity: 0.893 RM: (0.0, 0.0, 0.014905)
State: walk_start Velocity: 0.933 RM: (0.0, 0.0, 0.015553)
Changing state to: walk
State: walk Velocity: 0.000 RM: (0.0, 0.0, 0.0)
State: walk Velocity: 0.000 RM: (0.0, 0.0, 0.0)
State: walk Velocity: 0.000 RM: (0.0, 0.0, 0.0)
State: walk Velocity: 0.236 RM: (0.0, 0.0, 0.003931)
State: walk Velocity: 0.472 RM: (0.0, 0.0, 0.007862)
State: walk Velocity: 0.708 RM: (0.0, 0.0, 0.011793)
State: walk Velocity: 0.943 RM: (0.0, 0.0, 0.015723)
State: walk Velocity: 1.179 RM: (0.0, 0.0, 0.019654)
State: walk Velocity: 1.179 RM: (0.0, 0.0, 0.019654)
State: walk Velocity: 1.179 RM: (0.0, 0.0, 0.019654)
State: walk Velocity: 1.179 RM: (0.0, 0.0, 0.019654)
State: walk Velocity: 1.179 RM: (0.0, 0.0, 0.019654)
State: walk Velocity: 1.179 RM: (0.0, 0.0, 0.019654)
State: walk Velocity: 1.179 RM: (0.0, 0.0, 0.019654)
State: walk Velocity: 1.179 RM: (0.0, 0.0, 0.019654)
State: walk Velocity: 1.179 RM: (0.0, 0.0, 0.019654)
State: walk Velocity: 1.179 RM: (0.0, 0.0, 0.019654)
State: walk Velocity: 1.179 RM: (0.0, 0.0, 0.019654)
State: walk Velocity: 1.179 RM: (0.0, 0.0, 0.019654)
State: walk Velocity: 1.179 RM: (0.0, 0.0, 0.019654)
State: walk Velocity: 1.179 RM: (0.0, 0.0, 0.019654)
State: walk Velocity: 1.179 RM: (0.0, 0.0, 0.019654)
State: walk Velocity: 1.179 RM: (0.0, 0.0, 0.019654)
State: walk Velocity: 1.179 RM: (0.0, 0.0, 0.019654)
State: walk Velocity: 1.179 RM: (0.0, 0.0, 0.019654)
State: walk Velocity: 1.179 RM: (0.0, 0.0, 0.019654)
State: walk Velocity: 1.179 RM: (0.0, 0.0, 0.019654)
State: walk Velocity: 1.179 RM: (0.0, 0.0, 0.019654)
State: walk Velocity: 1.179 RM: (0.0, 0.0, 0.019654)
State: walk Velocity: 1.179 RM: (0.0, 0.0, 0.019654)
State: walk Velocity: 1.179 RM: (0.0, 0.0, 0.019654)
State: walk Velocity: 1.179 RM: (0.0, 0.0, 0.019654)
State: walk Velocity: 1.179 RM: (0.0, 0.0, 0.019654)
State: walk Velocity: 1.179 RM: (0.0, 0.0, 0.019654)
State: walk Velocity: 1.179 RM: (0.0, 0.0, 0.019654)
State: walk Velocity: 1.179 RM: (0.0, 0.0, 0.019654)
State: walk Velocity: 1.179 RM: (0.0, 0.0, 0.019654)
State: walk Velocity: 1.179 RM: (0.0, 0.0, 0.019654)
State: walk Velocity: 1.179 RM: (0.0, 0.0, 0.019654)
State: walk Velocity: 1.179 RM: (0.0, 0.0, 0.019654)
State: walk Velocity: 1.179 RM: (0.0, 0.0, 0.019654)
State: walk Velocity: 1.179 RM: (0.0, 0.0, 0.019654)
State: walk Velocity: 1.179 RM: (0.0, 0.0, 0.019654)
State: walk Velocity: 1.179 RM: (0.0, 0.0, 0.019654)
State: walk Velocity: 1.179 RM: (0.0, 0.0, 0.019654)
State: walk Velocity: 1.179 RM: (0.0, 0.0, 0.019654)
State: walk Velocity: 1.179 RM: (0.0, 0.0, 0.019654)
State: walk Velocity: 1.179 RM: (0.0, 0.0, 0.019654)
State: walk Velocity: 1.179 RM: (0.0, 0.0, 0.019654)
State: walk Velocity: 1.179 RM: (0.0, 0.0, 0.019654)
State: walk Velocity: 1.179 RM: (0.0, 0.0, 0.019654)
State: walk Velocity: 1.179 RM: (0.0, 0.0, 0.019654)
State: walk Velocity: 1.179 RM: (0.0, 0.0, 0.019654)
State: walk Velocity: 1.179 RM: (0.0, 0.0, 0.019654)
Changing state to: run_16
State: run_16 Velocity: 1.179 RM: (0.0, 0.0, 0.019654)
State: run_16 Velocity: 1.179 RM: (0.0, 0.0, 0.019654)
State: run_16 Velocity: 1.745 RM: (0.0, 0.0, 0.029086)
State: run_16 Velocity: 2.311 RM: (0.0, 0.0, 0.038519)
State: run_16 Velocity: 2.877 RM: (0.0, 0.0, 0.047951)
State: run_16 Velocity: 3.443 RM: (0.0, 0.0, 0.057383)
State: run_16 Velocity: 4.009 RM: (0.0, 0.0, 0.066814)
State: run_16 Velocity: 4.009 RM: (0.0, 0.0, 0.066815)
State: run_16 Velocity: 4.009 RM: (0.0, 0.0, 0.066815)
State: run_16 Velocity: 4.009 RM: (0.0, 0.0, 0.066815)
State: run_16 Velocity: 4.009 RM: (0.0, 0.0, 0.066815)
State: run_16 Velocity: 4.009 RM: (0.0, 0.0, 0.066815)
State: run_16 Velocity: 4.009 RM: (0.0, 0.0, 0.066815)
State: run_16 Velocity: 4.009 RM: (0.0, 0.0, 0.066815)
State: run_16 Velocity: 4.009 RM: (0.0, 0.0, 0.066815)
State: run_16 Velocity: 4.009 RM: (0.0, 0.0, 0.066815)
State: run_16 Velocity: 4.009 RM: (0.0, 0.0, 0.066815)
State: run_16 Velocity: 4.009 RM: (0.0, 0.0, 0.066815)
State: run_16 Velocity: 4.009 RM: (0.0, 0.0, 0.066815)
State: run_16 Velocity: 4.009 RM: (0.0, 0.0, 0.066815)
State: run_16 Velocity: 4.009 RM: (0.0, 0.0, 0.066815)
State: run_16 Velocity: 4.009 RM: (0.0, 0.0, 0.066815)
State: run_16 Velocity: 4.009 RM: (0.0, 0.0, 0.066815)
State: run_16 Velocity: 4.009 RM: (0.0, 0.0, 0.066815)
State: run_16 Velocity: 4.009 RM: (0.0, 0.0, 0.066815)
State: run_16 Velocity: 4.009 RM: (0.0, 0.0, 0.066815)
State: run_16 Velocity: 4.009 RM: (0.0, 0.0, 0.066815)
State: run_16 Velocity: 4.009 RM: (0.0, 0.0, 0.066815)
State: run_16 Velocity: 4.009 RM: (0.0, 0.0, 0.066815)
State: run_16 Velocity: 4.009 RM: (0.0, 0.0, 0.066815)

fire7side

It kind of looks like animation tree is more setup for root motion. Might be worth a try. Then again, you might have exactly the same problem.

« Previous Page