Trouble with scaling RectangleShape2D

DeveL

Hi,

I've been trying to create some borders for my game, but I'm facing some kind of scaling issue. I want to create my borders using RectangleShape2D, which extents across the width of the game window at the top and bottom edges. The problem I'm facing is that the borders don't position or extent like I hoped they would. The bottom border is placed at half the window height and even though the top border is placed correctly, both span only half the window width. Removing the test width makes them extent about 4/5 of the window width and the bottom border positions itself at 3/4 of the window height. I don't know what is causing the problem, but the only thing that has worked so far is setting the windowHeight and windowWidth to 1920 and 1080 manually in DeviceManager.gd.

I have my window size set to 1920 x 1080 and the test window size set to 1024 x 600. Here are the relevant codes:

DeviceManager.gd

class_name DeviceManager

var windowWidth = OS.get_window_size().x
var windowHeight = OS.get_window_size().y

var halfWindowWidth = windowWidth / 2
var halfWindowHeight = windowHeight / 2

BorderClass.gd

class_name BorderClass
extends StaticBody2D

var deviceManager = DeviceManager.new()

export var innerThickness = 0
export var outerThickness = 20

var halfThickness = (innerThickness + outerThickness) / 2

var topBorderPosition = Vector2(deviceManager.halfWindowWidth, innerThickness - halfThickness)
var bottomBorderPosition = Vector2(deviceManager.halfWindowWidth, deviceManager.windowHeight + halfThickness - innerThickness)

var topBorderExtent = Vector2(deviceManager.halfWindowWidth, halfThickness)
var bottomBorderExtent = Vector2(deviceManager.halfWindowWidth, halfThickness)

var topBorder = [topBorderExtent, topBorderPosition]
var bottomBorder = [bottomBorderExtent, bottomBorderPosition]

var borderData = [topBorder, bottomBorder]

Borders.gd

extends BorderClass

var shape
var shapeOwner

func _ready():
	create_border()


func create_border():
	
	for data in borderData:
		shape = RectangleShape2D.new()
		shape.extents = data[0]
		shapeOwner = create_shape_owner(self)
		shape_owner_set_transform(shapeOwner, Transform2D(0, data[1]))
		shape_owner_add_shape(shapeOwner, shape)

I have also attached some pictures to better illustrate where the borders are positioned and end.

I have set the test window size to 1024 x 600 in the first picture and I have remove the test width on the second picture.

As you can see, neither has the bottom border at the edge of the window and neither spans across the window width. Can someone please help me?

Toxe

DeveL I have no experience with Godot 3 but in 4 you can get the Viewport and Window of a Node. Maybe try those sizes instead of getting the OS window size.

DeveL

Toxe Thank you! I tried the get_viewport_rect() method on a simpler version of the same project and it works. Now I need to find a way to implement it on the main version.

I think the issue right now is that the DeviceManager.gd is not attached to any node, therefore it can't access the viewport. I tried attaching it to a Node2D and inserting it to the scene tree. But I got this error:

 E 0:00:00.394   get_viewport_rect: Condition "!is_inside_tree()" is true. Returned: Rect2()
  <C++ Source>  scene/2d/canvas_item.cpp:944 @ get_viewport_rect()
  <Stack Trace> DeviceManager.gd:3 @ _init()
                ballClass.gd:4 @ _init()
                Ball.gd:0 @ _init()

EDIT: Hmm... oddly enough, setting stretched mode to disabled and Aspect to ignore seems to have fixed the issue. I wonder if it's because I'm creating and positioning everything through code instead of using sprites and the editor?

DaveTheCoder

I'm not sure if this is the problem, but I've found situations where referencing the size of a drawn element has to be done after the element has been drawn.