Animations only playing once

UnknownUser

my attack animation only plays one time and i deal damage one time. But my timer prints over and over. So shouldnt my animation play over when the timer starts over?

 func _ready():
        level = data.player.warriorlevel
        #$AnimatedSprite.connect("animation_finished", self, "on_animation_finished")
        cooldown = Timer.new()
        add_child(cooldown)
        cooldown.set_one_shot(true)
        cooldown.set_wait_time(attack_time)
        cooldown.connect("timeout", self, "_on_time_out")
    
    func attack():
        if is_attacking and enemy_here:
            cooldown.start()
            $AnimatedSprite.play("attack")
    
    func _on_attackarea_body_entered(body):
        print("hes here")
        enemy_here = true
        is_attacking = true
        attack()
        if body.has_method('take_damage'):
            body.take_damage(damage)
    
    
    func _on_attackarea_body_exited(body):
        is_attacking = false
        enemy_here = false
    
    #func _on_animation_finished(attack):
        #print("second")
        #$Cooldown.start()
    
    func _on_time_out():
        attack()
        print("third")

TwistedTwigleg

Welcome to the forums @steven440!

Which of the print statements is the one that is printing over and over? print("third")?

Taking a quick glance through the code, I think the issue may be that the _on_time_out function calls attack, which resets the timer on line 12 (cooldown.start). Additionally, it could be that is_attacking and enemy_here are set to false, but since the _on_time_out function does not check for this, it continues to print "third".

UnknownUser

Yes the print third is the one that prints over and over. Ill check that out and get back with an update

UnknownUser

SOLVED: i did a few things and ended up fixing it all. now my hero auto attacks when he collides with an enemy, and deals damage every time he attacks till the enemy dies.

extends "res://heros/hero.gd"

var level

var attack_time = 2
var cooldown
#var enemies_inside = {}


func _ready():
	level = data.player.warriorlevel
	cooldown = Timer.new()
	add_child(cooldown)
	cooldown.set_one_shot(false)
	cooldown.set_wait_time(attack_time)
	cooldown.connect("timeout", self, "_on_time_out")

func attack():
		cooldown.start()
		$AnimatedSprite.play("attack")

func _on_attackarea_body_entered(body):
	print("hes here")
	enemy_here = true
	is_attacking = true
	attack()


func _on_attackarea_body_exited(body):
	is_attacking = false
	enemy_here = false

func _on_time_out():
	if is_attacking and enemy_here:
		attack()
		print("third")


func _on_AnimatedSprite_animation_finished():
	if $AnimatedSprite.animation == "attack":
		$AnimatedSprite.stop()
		for body in $attackarea.get_overlapping_bodies():
			if body.has_method('take_damage'):
				body.take_damage(damage)
		print("second")

TwistedTwigleg

Great, I'm glad you got it working! (I edited the code in the solution slightly so there was less empty space and marked it as the answer to the question)