Player Moving to the wrong position (Position2d)

Anderoo99

My player is moving to the wrong position when using position2d. The code works as I want it to except that the player is moving a bit off from the correct position.

public override void _Ready()
{
	bodyAnimation = GetNode<AnimatedSprite>("Body");
	legsAnimation = GetNode<AnimatedSprite>("Legs");
	totalMovePoints = GetNode("MovePoints").GetChildCount();
	movePoints = GetNode("MovePoints");
	target = movePoints.GetChild<Position2D>(currentTargetNumber).GlobalPosition;
}
public override void _PhysicsProcess(float delta)
{
	if(!shouldMove)
	{
		shouldMove = true;
		if(currentTargetNumber == totalMovePoints - 1)
		{
			currentTargetNumber = 0;
		}
		else
		{
			currentTargetNumber += 1;
		}
		target = movePoints.GetChild<Position2D>(currentTargetNumber).GlobalPosition;
	}
	
	if((target - GlobalPosition).Length() < 2f)
	{
		GlobalPosition = target;
		shouldMove = false;
	}
	
	if(shouldMove)
	{
		MoveAndSlide((target - GlobalPosition).Normalized() * movementSpeed);
	}
}

Anderoo99

TwistedTwigleg

If I had to guess, the reason the position is slightly off is because the length of the distance the object is from the target isn't taken into account, so sometimes it overshoots it a bit and goes too far.

I think something like this might work:

public override void _Ready()
{
	bodyAnimation = GetNode<AnimatedSprite>("Body");
	legsAnimation = GetNode<AnimatedSprite>("Legs");
	totalMovePoints = GetNode("MovePoints").GetChildCount();
	movePoints = GetNode("MovePoints");
	target = movePoints.GetChild<Position2D>(currentTargetNumber).GlobalPosition;
}
public override void _PhysicsProcess(float delta)
{
	if(!shouldMove)
	{
		shouldMove = true;
		if(currentTargetNumber == totalMovePoints - 1)
		{
			currentTargetNumber = 0;
		}
		else
		{
			currentTargetNumber += 1;
		}
		target = movePoints.GetChild<Position2D>(currentTargetNumber).GlobalPosition;
	}
	
	if((target - GlobalPosition).Length() < 2f)
	{
		GlobalPosition = target;
		shouldMove = false;
	}
	
	if(shouldMove)
	{
		Vector2 positionToTarget = (target - GlobalPosition)
		if (movementSpeed * delta >= positionToTarget * delta)
		{
			MoveAndSlide((target - GlobalPosition).Normalized() * movementSpeed);
		}
		else
		{
			MoveAndSlide(positionToTarget)
		}
	}
}

I have not tested the code, and I have not done much C# with Godot, but I think that should fix the issue. Now when movement_speed is more than the length of the distance to the target, it will instead use the the distance to the target so that it does not go too far.

(We multiply by delta in the comparisons because MoveAndSlide automatically multiplies by delta, I think...)

I do not know if the code above will work for sure, but that is what I would try. :smile:

Anderoo99

Hey, I dont think that is the problem. The change in direction occur after 100s of frames. I tried using the code you have given but it shows the following error Operator '>=' cannot be applied to operands of type 'float' and 'Vector2' (CS0019) [BYOG Game] for movementSpeed delta >= positionToTarget delta

Anderoo99

@Anderoo99 said: Hey, I dont think that is the problem. The change in direction occur after 100s of frames. I tried using the code you have given but it shows the following error Operator '>=' cannot be applied to operands of type 'float' and 'Vector2' (CS0019) [BYOG Game] for movementSpeed delta >= positionToTarget delta

It seems as if the position has shifted. I am only using global positions and setting the POsition2d nodes as top level. I just cannot understand why this error occurs

TwistedTwigleg

Hey, I dont think that is the problem. The change in direction occur after 100s of frames. I tried using the code you have given but it shows the following error

Hmm, strange. Maybe something gets slightly out of sync after awhile?

I know why the code isn't working at least. I forgot a line. If you change if (movementSpeed * delta >= positionToTarget * delta) to if (movementSpeed * delta >= positionToTarget.Length() * delta) then it should work.

It seems as if the position has shifted. I am only using global positions and setting the POsition2d nodes as top level. I just cannot understand why this error occurs

Maybe something is moving it? Maybe try printing the position of the point(s) that are causing an issue and see if console shows a change in position?

Looking at the scene picture, the object you are moving is EnemyGenin and you are trying to move to the points in MovePoints, right?

If that is the case, then the issue is likely because the points in MovePoints are being moved because they are children of the EnemyGenin node, so they move as EnemyGenin moves.

You might need to move the MovePoints nodes outside of the EnemyGenin scene and/or cache global positions of the points so that EnemyGenin's movement doesn't change the position of the MovePoints nodes.

Anderoo99

@TwistedTwigleg said:

Hey, I dont think that is the problem. The change in direction occur after 100s of frames. I tried using the code you have given but it shows the following error

Hmm, strange. Maybe something gets slightly out of sync after awhile?

I know why the code isn't working at least. I forgot a line. If you change if (movementSpeed * delta >= positionToTarget * delta) to if (movementSpeed * delta >= positionToTarget.Length() * delta) then it should work.

It seems as if the position has shifted. I am only using global positions and setting the POsition2d nodes as top level. I just cannot understand why this error occurs

Maybe something is moving it? Maybe try printing the position of the point(s) that are causing an issue and see if console shows a change in position?

Looking at the scene picture, the object you are moving is EnemyGenin and you are trying to move to the points in MovePoints, right?

If that is the case, then the issue is likely because the points in MovePoints are being moved because they are children of the EnemyGenin node, so they move as EnemyGenin moves.

You might need to move the MovePoints nodes outside of the EnemyGenin scene and/or cache global positions of the points so that EnemyGenin's movement doesn't change the position of the MovePoints nodes.

Hey, I was able to fix the problem. My character was not at position 0,0. So when the positions 2d nodes were getting set to top level, the local position of the nodes were getting set as its global position. It was an easy fix once I found out. I just set the local position = global position. Thanks for the reply?

TwistedTwigleg

No problem, I’m glad you were able to figure it out!