(ANSWERED) crawl animation stuck on first frame (noob problems)

viloafi

Hi all, I'm new here and I'm teaching my self to code and all the rest. I am having a tad of trouble getting an animation to play. I have googled for ages and no luck. and I feel like the more I try to fix it the more needless code I put in.

Problem:

crawling animation does not cycle: stuck on the first frame.

code:

if Input.is_action_pressed("ui_down"):
	if on_ground == true:
		velocity.x = 0
		$AnimatedSprite.play("duck")
		duck = true
	else:
		duck = false
	if duck == true && Input.is_action_pressed("ui_right"):
		velocity.x = SPEED * 0.3
		$AnimatedSprite.play("crawl") 
		$AnimatedSprite.flip_h = false
		crawl = true
	elif duck == true && Input.is_action_pressed("ui_left"):
		velocity.x = -SPEED * 0.3
		$AnimatedSprite.play("crawl") 
		$AnimatedSprite.flip_h = true
		crawl = true
else:
		crawl = false

I think it is clashing with:

func _physics_process(delta):

if crawl == false && Input.is_action_pressed("ui_right"):
	velocity.x = SPEED
	$AnimatedSprite.play("walk") 
	$AnimatedSprite.flip_h = false
elif crawl == false && Input.is_action_pressed("ui_left"):
	velocity.x = -SPEED
	$AnimatedSprite.play("walk") 
	$AnimatedSprite.flip_h = true
else:
	velocity.x = 0 
	if on_ground == true:
		$AnimatedSprite.play("idle")

If you think I should post the whole code let me know.

Any and all help greatly appreciated :)

also, you are devilishly good looking ;p

TwistedTwigleg

I haven't taken a close look at the code, but the issue is probably that the animation doesn't have time to change animation frames before it is being reset through the play function.

The play function resets the frame count to 0 when called, so the new animation starts at the beginning. Where this becomes an issue is that it does not check to see if the animation name passed is the same animation that is already playing or not, and so it resets the frame count to 0 even though the animation has not changed.

If this the play function is called repeatedly every time the player moves/walks/falls/etc, then only the first frame of the animation will be shown because the frame count will constantly be reset to 0 by the play function.

A simple way to fix this is to check to see if the animation playing is different than the animation you want to play before you change animations. For example:

# If the animation is not the crawl animation, but the crawl animation
# is supposed to play, then change animations!
if $AnimatedSprite.animation != "crawl":
	$AnimatedSprite.play("crawl")

That should allow the crawl animation to play. :smile:

Hopefully this helps! (Side note: Welcome to the forums)

viloafi

Hey thanks,

this makes a lot of sense. I will give it a go when I finish work.

Thanks heaps

viloafi

No sorry, this didn't seem to change anything @TwistedTwigleg . i think i will try adding an animation tree rather than coding it in, might work. all other animations work perfectly here is the whole code so far with Twisted's suggestion (it may be in the wrong place tho i have put it all over the code to no avail) if any keen eyes can spot my mistake plz let me know

thanks

extends KinematicBody2D



const FLOOR = Vector2(0, -1)
const JUMP_POWER = -800
const SPEED = 550
const GRAVITY = 35
var velocity = Vector2()
var on_ground = false
var floating = false
var fall = false
var duck = false
var crawl = false

func _physics_process(delta):
	
	
		
	if crawl == false && Input.is_action_pressed("ui_right"):
		velocity.x = SPEED
		$AnimatedSprite.play("walk") 
		$AnimatedSprite.flip_h = false
	elif crawl == false && Input.is_action_pressed("ui_left"):
		velocity.x = -SPEED
		$AnimatedSprite.play("walk") 
		$AnimatedSprite.flip_h = true
	else:
		velocity.x = 0 
		if on_ground == true:
			$AnimatedSprite.play("idle") 
		

	if Input.is_action_pressed("ui_up"):
		if on_ground == true:
			velocity.y = JUMP_POWER
			on_ground = false
	
	if is_on_floor():
		on_ground = true
	else:
		on_ground = false
		if velocity.y > 0:
			fall = true
			$AnimatedSprite.play("fall")
		if velocity.y < 0:
			$AnimatedSprite.play("jump")
			
	if fall == true && Input.is_action_pressed("ui_home") && on_ground == false:
		velocity.y = GRAVITY * .9999999999
		$AnimatedSprite.play("floating")
		floating = true
		
		
		
	
	
	
 
		

	if Input.is_action_pressed("ui_down"):
		if on_ground == true:
			velocity.x = 0
			$AnimatedSprite.play("duck")
			duck = true
		else:
			duck = false
		if Input.is_action_pressed("ui_down") == true && Input.is_action_pressed("ui_right"):
			velocity.x = SPEED * 0.3
			if $AnimatedSprite.animation != "crawl":
				$AnimatedSprite.play("crawl") 
				$AnimatedSprite.flip_h = false
			crawl = true
		elif Input.is_action_pressed("ui_down") == true && Input.is_action_pressed("ui_left"):
			velocity.x = -SPEED * 0.3
			if $AnimatedSprite.animation != "crawl":
				$AnimatedSprite.play("crawl") 
				$AnimatedSprite.flip_h = true
			crawl = true
	else:
			crawl = false

		
			



	velocity.y += GRAVITY
	
	



	
	velocity = move_and_slide(velocity, FLOOR)

TwistedTwigleg

Hmm, I looking at the code I do not see anything that should be causing the issue.

The only thing I can think of that might be causing the issue is the following code:

	if Input.is_action_pressed("ui_down"):
		if on_ground == true:
			velocity.x = 0
			$AnimatedSprite.play("duck")
			duck = true
		else:
			duck = false
		if Input.is_action_pressed("ui_down") == true && Input.is_action_pressed("ui_right"):
			velocity.x = SPEED * 0.3
			if $AnimatedSprite.animation != "crawl":
				$AnimatedSprite.play("crawl") 
				$AnimatedSprite.flip_h = false
			crawl = true
		elif Input.is_action_pressed("ui_down") == true && Input.is_action_pressed("ui_left"):
			velocity.x = -SPEED * 0.3
			if $AnimatedSprite.animation != "crawl":
				$AnimatedSprite.play("crawl") 
				$AnimatedSprite.flip_h = true
			crawl = true
	else:
		crawl = false

I wonder if what is happening is that the duck animation is being played before the code for crawling is executed. If that is the case, then the animation would change to duck before changing to crawl shortly after.

If this is the issue, then the reordering the code should, hopefully, fix the issue.

	if Input.is_action_pressed("ui_down"):
		if on_ground == true:
			if Input.is_action_pressed("ui_right"):
				velocity.x = SPEED * 0.3
				if $AnimatedSprite.animation != "crawl":
					$AnimatedSprite.play("crawl")
				$AnimatedSprite.flip_h = false
			elif Input.is_action_pressed("ui_left"):
				velocity.x = SPEED * 0.3
				if $AnimatedSprite.animation != "crawl":
					$AnimatedSprite.play("crawl")
				$AnimatedSprite.flip_h = true
			else:
				velocity.x = 0
				$AnimatedSprite.play("duck")
				duck = true
		else:
			duck = false
	else:
		crawl = false

I'm not sure if my earlier code for checking the animated sprite is needed anymore, so if this fixes the issue you might want to see if removing it does anything.

But other than the duck animation playing before the code for the crawl animation, I do not see anything that would be causing the issue. I'll try to take another look tomorrow, maybe that will help.

Using an animation tree might be the way to go, though I have not used it in Godot so I'm not totally sure.

viloafi

No dice I'm afraid

viloafi

Sweet got it, a bit of trial and error but got there in the end

Thank you @TwistedTwigleg " may a thousand fleas infest the armpits of your enemies "

if you can see any improvements to my code please let me know always keen to learn :)

if Input.is_action_pressed("ui_down") && on_ground == true:
		duck = true
		if duck == true && Input.is_action_pressed("ui_right"):
			velocity.x = SPEED * 0.2
			crawl = true
			if $AnimatedSprite.animation != "crawl":
				$AnimatedSprite.play("crawl") 
				$AnimatedSprite.flip_h = false
		elif duck == true && Input.is_action_pressed("ui_left"):
			velocity.x = -SPEED * 0.2
			crawl = true
			if $AnimatedSprite.animation != "crawl":
				$AnimatedSprite.play("crawl") 
				$AnimatedSprite.flip_h = true
		if crawl == false && duck == true:
			$AnimatedSprite.play("duck")
	else:
		crawl = false 
		duck = false

viloafi

also didn't need the != so i got rid of it. may come in handy later tho tyvm

TwistedTwigleg

Awesome! Glad you got it working :smile: