Trying to fix my shop system and add a new part to it

Danicron

I added a new part to my script however i cant figure out how to integrate it and make it work, i am trying to add a Damage int to the weapon that i will later use in conjunction with attack modifiers and such but however ive fiddled around with it  a while and i cant seem to figure out how to get it to be a column in the ItemList or how to get the Damage Ints for each weapon to show up


extends ItemList
	var buystuff = load ("res://Charatabs.gd")
	
	
	var SHOP_ITEMS = {
		
	   #Swords
	    "LongSword":{"sold":false,"Damage":4, "type":"Sword", "cost":10},
	    "Rapier":{"sold":false, "Damage":7, "type":"Sword", "cost":25},
	    "Scimitar":{"sold":false, "Damage":12, "type":"Sword", "cost":40},
	    "BroadSword":{"sold":false, "Damage":20, "type":"Sword", "cost":60},
	    "BastardSword":{"sold":false, "Damage":35, "type":"Sword", "cost":100},  

	    "Excalibur":{"sold":false, "Damage":150, "type":"Sword", "cost":500},
		#Daggers
		"RogueDagger":{"sold":false, "Damage":3, "type":"Dagger", "cost":10},
	    "Shank":{"sold":false, "Damage":10, "type":"Dagger", "cost":20},
	    "LongKnife":{"sold":false, "Damage":18, "type":"Dagger", "cost":30},
	    "AssassinBlade":{"sold":false, "Damage":30, "type":"Dagger", "cost":50},
	    "MurderWeapon":{"sold":false, "Damage":60, "type":"Dagger", "cost":80},
	}
	var selected_item_name = null;
	func _ready():
	    add_item("Weapon Name", null, false);
	    add_item("Damage", null, false);
	    add_item("Weapon Type", null, false);
	    add_item("Cost", null, false);
	    # Add each item.
	    for item_name in SHOP_ITEMS:
	        add_item(item_name, null, SHOP_ITEMS[item_name]["sold"]);
	        add_item(SHOP_ITEMS[item_name]["type"], null, false);
	        add_item(str(SHOP_ITEMS[item_name]["cost"]), null, false);
	    # Connect the item_selected signal so we know when a item in the list is selected.
	    connect("item_selected", self, "shop_item_selected");
	func shop_item_selected(index):
	    # Get the name of the selected item
	    selected_item_name = get_item_text(index);
	    # Check if name is a name of a item in the shop (and the type/cost of a item)
	    if (SHOP_ITEMS.has(selected_item_name) == true):
	        print ("Item selected: ", selected_item_name, " | Cost: ", SHOP_ITEMS[selected_item_name]["cost"]); 
			
		
		
	func _on_Button_pressed():
		get_node("/root/global").goto_scene("res://TownMap.tscn")
	
	
	func _on_Buy_pressed():
		if (buystuff.current_tab() == 0)  &&  Coins.warrior_coins >= SHOP_ITEMS[selected_item_name]["cost"]:
			Coins.warrior_coins -= SHOP_ITEMS[selected_item_name]["cost"]
			print (Coins.warrior_coins)

Also this part at the bottom here is me trying to set it up so that when an item is selected and a characters tab is the current tab then it will deduct money from the particular characters coins however i cant get it to see which tab is the current tab as i just get an error that says Invalid Function

TwistedTwigleg

@Danicron said:

I added a new part to my script however i cant figure out how to integrate it and make it work, i am trying to add a Damage int to the weapon that i will later use in conjunction with attack modifiers and such but however ive fiddled around with it a while and i cant seem to figure out how to get it to be a column in the ItemList or how to get the Damage Ints for each weapon to show up

You just need to add the following line inside the for loop

# Add each item.
for item_name in SHOP_ITEMS:
	add_item(item_name, null, SHOP_ITEMS[item_name]["sold"]);
	# New line HERE!
	add_item(str(SHOP_ITEMS[item_name]["damage"]), null, false);
	add_item(SHOP_ITEMS[item_name]["type"], null, false);
	add_item(str(SHOP_ITEMS[item_name]["cost"]), null, false);

Also this part at the bottom here is me trying to set it up so that when an item is selected and a characters tab is the current tab then it will deduct money from the particular characters coins however i cant get it to see which tab is the current tab as i just get an error that says Invalid Function

It is because current_tab is a property and not a function. For example, in your script selected_item_name is a property (a value you can change), while _ready is a function.

All you need to do is remove the () from buystuff.current_tab() == 0 so it is buystuff.current_tab == 0 instead :smile:

(Since buystuff is a script which you are loading, it presumably has not been instanced into the scene. This may make it where you cannot get the current_tab property from buystuff, but without testing/looking-at the project, it is hard to say if it will be an issue though. This is just something to keep in mind if other errors pop up)

Danicron

i tried removing the brackets from the property but now im getting a different error, also the script i am using doesnt have an attached node so im not sure how to instance it exactly, here is an image of the error Ohhhhh wait hang on yes that script is the script from my Characters tabs node, however when i tried to get_node it , it kepts saying it couldnt find it so i just loaded the script from it instead, is there a better way?

Danicron

the reason im getting confused is because i renamed the tabs as the previous script was being used by two nodes in different scenes and it was going all kinds of crazy

TwistedTwigleg

@Danicron said: i tried removing the brackets from the property but now im getting a different error, also the script i am using doesnt have an attached node so im not sure how to instance it exactly, here is an image of the error! Ohhhhh wait hang on yes that script is the script from my Characters tabs node, however when i tried to get_node it , it kepts saying it couldnt find it so i just loaded the script from it instead, is there a better way?

Yeah, you need to use get_node so you can access the node with the script, rather than the script itself. Here is what I would do: Expose a NodePath to the editor, and then in the editor set the NodePath to the Character Tabs node.

Here is what you'll need to add to your script to get that working:

export (NodePath) var path_to_buystuff_node
var buystuff
func _ready():
	buystuff = get_node(path_to_buystuff_node)

Just add that to your script, and then set the NodePath in the editor. Then you should be able to get the node and then access the current_tab property within it.

Danicron

@TwistedTwigleg said:

@Danicron said: i tried removing the brackets from the property but now im getting a different error, also the script i am using doesnt have an attached node so im not sure how to instance it exactly, here is an image of the error! Ohhhhh wait hang on yes that script is the script from my Characters tabs node, however when i tried to get_node it , it kepts saying it couldnt find it so i just loaded the script from it instead, is there a better way?

Yeah, you need to use get_node so you can access the node with the script, rather than the script itself. Here is what I would do: Expose a NodePath to the editor, and then in the editor set the NodePath to the Character Tabs node.

Here is what you'll need to add to your script to get that working:
export (NodePath) var path_to_buystuff_node
var buystuff
func _ready():
	buystuff = get_node(path_to_buystuff_node)
Just add that to your script, and then set the NodePath in the editor. Then you should be able to get the node and then access the current_tab property within it.

Thank you sooo much its finally starting to come together!! :):) and now that i have tab working with the buy button i can finish that off and start on the other 4 shops lol and then the Inn which im hoping will be easier at least because i dont have to have the ItemList. Thanks again :), i will definitely be mentioning you in my game credits :)

TwistedTwigleg

@Danicron said:
@TwistedTwigleg said:

@Danicron said: i tried removing the brackets from the property but now im getting a different error, also the script i am using doesnt have an attached node so im not sure how to instance it exactly, here is an image of the error! Ohhhhh wait hang on yes that script is the script from my Characters tabs node, however when i tried to get_node it , it kepts saying it couldnt find it so i just loaded the script from it instead, is there a better way?

Yeah, you need to use get_node so you can access the node with the script, rather than the script itself. Here is what I would do: Expose a NodePath to the editor, and then in the editor set the NodePath to the Character Tabs node.

Here is what you'll need to add to your script to get that working:
export (NodePath) var path_to_buystuff_node
var buystuff
func _ready():
	buystuff = get_node(path_to_buystuff_node)
Just add that to your script, and then set the NodePath in the editor. Then you should be able to get the node and then access the current_tab property within it.
Thank you sooo much its finally starting to come together!! :):) and now that i have tab working with the buy button i can finish that off and start on the other 4 shops lol and then the Inn which im hoping will be easier at least because i dont have to have the ItemList. Thanks again :), i will definitely be mentioning you in my game credits :)

No problem, happy to help how I can. If you want to mention me the in credits, I would be honored, but if not that is fine too. Either way is cool with me. I just try to help others where I can, especially if I know something that might be able to help :smile: