How should i call a variable from another scene?

mdswamp

this question asked multiple times, but i couldn't figured it out how to use it in my script when it become complicated.. i have 4 scene, i want call a variable from player01 node in "players" scene and use it in "main game" scene. "players" scene is instance scene of "main game" my main scene in project setting is "starting game" if it helps. thank you (i use godot v2.1)

TwistedTwigleg

I am a little confused on what you are asking. You have a object that is instanced into a scene (Players) and you are wanting to access a variable in another scene (MainGame) and both scenes are instanced in StartingGame?

Regardless, all you need to do to access a variable in another scene is get a reference to it. The easiest way to get a reference is to use get_node and pass in the path to the node you want to get. Getting the path can be trickier, but you can get around some of the complexities by letting the Godot editor help you along.

For example, if you this code will get a variable from whatever scene the exported NodePath is pointing to:

extends Node2D export (NodePath) var path_to_external_node; var external_node; func _ready(): external_node = get_node(path_to_external_node); "Access a variable" external_node.bar = 3; "Access a function" external_node.do_thing(); func _fixed_process(delta): external_node.bar += 2; print (external_node.bar);

This assumes whatever node you are pointing to has a variable called bar and a function called do_thing, and it also assumes you have set a NodePath in the inspector before running the project.

Hopefully this helps!

mdswamp

Hi @TwistedTwigleg , sry for confusing comment :| i managed to call my variables, but the problem is that it seems it returns default value..

onready var score1 = get_tree().get_root().get_node("/root/MainGame").score1
onready var score2 = get_tree().get_root().get_node("/root/MainGame").score2

func _ready():
        if score1>score2:
           get_node("WhoWin").set("text","PLAYER ONE WINS")
        else:
           get_node("WhoWin").set("text","PLAYER TWO WINS")

score1 and score2 define like (var score1 = 0; var score2 = 0) in MainGame.tscn and "WhoWin" is a Label node.

default value for score1 and score2 is 0 in MainGame.tscn and when i compare these variables (if score1>score2), it always returns (,"PLAYER TWO WINS"), thats why i think it just gets default values (0). can you help me with this, thanks.. :)

P.S: when i use print in MainGame.tscn to see which player wins the game, it returns the correct one. i mean my data before calling them in another node are correct

TwistedTwigleg

Hi @TwistedTwigleg , sry for confusing comment :|

No reason to apologize! I just had a hard time figuring out what has happening, that's all :smile:

i managed to call my variables, but the problem is that it seems it returns default value..

Hmm, well there could be two different things at work here.

One thing that could be causing the issue is the order in your scene tree. For example, suppose you have the following nodes in the following order in a scene.

-| Node_1 -| Node_2

And let's say both have a variable called foo which is set to 4 by default, but in the _ready function, each node changes foo to 2. Finally, let's say you are printing both Node_1 and Node_2's foo variable in each _ready function (using code like print("Node_1 print statement: Node_1.foo = ", self.foo, ", Node_2.foo = ", get_parent().get_node("Node_2").foo) for Node_1 and similar code for Node_2)

The output from the example would look like this:

Node_1 print statement: Node_1.foo = 2, Node_2.foo:4 Node_2 print statement: Node_1.foo = 2, Node_2.foo:2

Because of how Godot executes _ready, when Node_1 prints both foo values, for Node_2 the value is still in it's default state. This is because Godot calls _ready going down the scene tree, and because Node_1 is above Node_2 in the scene tree, Node_2's _ready function has not been called yet.

So it could be that when you are accessing score1 and score2 from MainGame, _ready has not been called yet in MainGame because it is lower in the scene tree.

Another thing that could be causing the issue is how you have your if statements setup. In the code for checking score, you are checking to see if score1 is greater than score2 (using if score1>score2) and if it does you are setting the text saying that player 1 wins.

However, if score1 is not greater than score2, you are setting the text saying that player two wins.

Because you are using else, this means any time the if statement (score1 being higher than score2) is false, it is going to set the text to show that player 2 wins. This means both score2 being higher than score1 will set the text to show player 2 has won (because score2 is more than score1) and when both scores are equal it will set the text to show player 2 has won (because score1 is not greater than score2, but rather they are equal).

Thankfully the fix is really simple. You just need to replace _ready with the following code:

func _ready(): if score1>score2: get_node("WhoWin").set("text","PLAYER ONE WINS") elif score<score2: get_node("WhoWin").set("text","PLAYER TWO WINS") else: pass; "Equal scores!"

Hopefully this helps!

Edit: Just saw your comment (we must have been writing at the same time :lol: ) No worries, you were not bothering me. Glad you figured it out :)

mdswamp

ok, i found the answer, i should put the "if" in process function, i thought i should put it in ready function, thank you for the precious info twisted, sorry to bother you.

Edit: but thank you very much, i didn't know these Priorities, i'd just thought about them :D

raincoat

Hey there!

I just want to make it simple for me because like an one week I am just try to figure out.

Here what I want to try:

I have one "LineEdit" in scene named with SendVar.tscn. It have one Control node named Data and her child is LineEdit. And my another scene is ReceiveVar.tscn. It have a Control node also named with Receive and her child is Label.

So I am trying to make when I write a name in LineEdit (in SendVar.tscn) I want to print in ReceiveVar.tscn's Label.

Like: (SendVar.tscn) [Type a name] >> Godot (ReceiveVar.tscn) Hello Godot!

~~How can I do that? I am really beginner so I don't know even if this is possible or not in GDScript.~~

Thank you so much. I hope my bad English would not bother you all.

Cheers.

EDIT: I find the solution.

Okay finally I figure it out how to do that. I want to share my solution for people who like me and looking for answer.

First need to read this: https://docs.godotengine.org/en/3.1/getting_started/step_by_step/singletons_autoload.html?highlight=autoload#autoload

I create a GdScript file which no where attachment. And I named it Send.gd. Then I made steps from the doc (link on top). Project Settings -> Auto Load. Then I added this Send.gd into it. Then I go back to Send.gd and I create some variables like name. And I call these variables from SendVar and I edid them and then I call these variables again from ReceiveVar.

So my scripts are look like this: Send.gd - No attachment only in AutoLoad:

# It need extends only 'Node', nothing else (?)
extends Node
# This variable will be replaced with what into in LabelText
var what_name = "no name"

SendVar.gd - Attachment in SendVar.tscn

extends Control

# First we are creating another variable which would start in ready and we call the Auto Loaded file in this case it name is Send
# Which name you call it in AutoLoad window you need print it here correctly.
onready var name = get_node("/root/Send")

func _ready():
	pass
# I've just connected a signal that If user press enter this script will work.
func _on_LineEdit_text_entered(data):
	# This 'data' is coming from what user type in it.
	# And we are calling the what_name variable from Send.gd script.
	# And we are updating with the data which user just typed.
	name.what_name = data
	# After do that we are going another scene that we call ReceiveVar.tscn
        get_tree().change_scene("res://ReceiveVar.tscn")

And the last thing is how to read this updated variable in another scene which in this case I called ReceiveVar. It have only an one Label so it must look like this:

ReceiveVar.gd - Attachment in ReceiveVar.tscn

extends Control
# Same with SendVar.gd
onready var name = get_node("/root/Global")

func _ready():
	#Short way of get_node("Label").text
	$Label.text = "Hello " + name.what_name + "\n Welcome the Godot!"

So this is how I start to send variables to another scenes. I don't know if this is more optimize solution or not because I am just a beginner with awful English. So just try to understand what's going on.

But it works at least for me now.

Thank you all.