Error on Pong

SirBothersome

Hi, I'm new to Godot, and In the process of of trying to learn it, I'm making the Pong project in the tutorial docs, however, I keep getting a bug. either a) [code]extends Node2D# member variables here, example:# var a=2# var b="textvar"var screen_sizevar pad_sizefunc ready():  screen_size = get_viewport_rect().size  pad_size = get_node("left").get_texture().get_size()  set_process(true)  var ball_speed = 80  var direction = Vector2(-1, 0)  var PAD_SPEED = 150func process(delta):      var ball_pos = get_node("ball").get_pos()      var left_rect = Rect2( get_node("left").get_pos() - pad_size/2, pad_size )      var right_rect = Rect2( get_node("right").get_pos() - pad_size/2, pad_size)      ball_pos += direction ball_speed delta            if ( (ball_pos.y < 0 and direction.y < 0) or (ball_pos.y > screen_size.y and direction.y > 0)):        direction.y = -direction.y              if  ( (left_rect.has_point(ball_pos) and direction.x < 0) or (right_rect.has_point(ball_pos) and direction.x > 0)):        direction.x = -direction.x      ball_speed += 1.1      direction.y = randf() + 2.0 - 1      direction = direction.normalized()      if (ball_pos.x < 0 or ball_pos.x > screen_size.x):        ball_pos = screen_size 0.5 # ball goes to screem center        ball_speed = 80        direction = Vector2(-1, 0)        get_node("ball").set_pos(ball_pos)    # move left pad      var left_pos = get_node("left").get_pos()        if (left_pos.y > 0 and Input.is_action_pressed("left_move_up")):        left_pos.y += -PAD_SPEED delta      if (left_pos.y < screen_size.y and Input.is_action_pressed("left_move_down")):        left_pos.y += PAD_SPEED delta                get_node("left").set_pos(left_pos)                var right_pos = get_node("right").get_pos()        if (right_pos.y > 0 and Input.is_action_pressed("right_move_ip")):            right_pos.y += -PAD_SPEED delta            if (right_pos.y < screen_size.y and Input.is_action_pressed("right_move_down")):              right_pos.y += PAD_SPEED * delta                            get_node("right").set_pos(right_pos)         # Called every time the node is added to the scene.  # Initialization here      pass[/code]Produces. "Parser error, Identifier not found: direction"or b) having PAD_SPEED as a const generates "error parsing expression: misplaced const". anyhelp?

existentia

You're defining var direction inside the ready() function but calling it from process(). Move that up with screen_size and pad_size and it ought to be OK.

SirBothersome

Fixed the indentation issues as well as the + instead of 's. NOW, this code[code]extends Node2D# member variables here, example:# var a=2# var b="textvar"var screen_sizevar pad_sizefunc ready():  screen_size = get_viewport_rect().size  pad_size = get_node("left").get_texture().get_size()  set_process(true)var ball_speed = 80var direction = Vector2(-1, 0)const PAD_SPEED = 150    func process(delta):  var ball_pos = get_node("ball").get_pos()  var left_rect = Rect2( get_node("left").get_pos() - pad_size/2, pad_size )  var right_rect = Rect2( get_node("right").get_pos() - pad_size/2, pad_size)  ball_pos += direction ball_speed delta        if ( (ball_pos.y < 0 and direction.y < 0) or (ball_pos.y > screen_size.y and direction.y > 0)):      direction.y = -direction.y          if  ( (left_rect.has_point(ball_pos) and direction.x < 0) or (right_rect.has_point(ball_pos) and direction.x > 0)):          direction.x = -direction.x  ball_speed = 1.1  direction.y = randf() 2.0 - 1  direction = direction.normalized()  if (ball_pos.x < 0 or ball_pos.x > screen_size.x):      ball_pos = screen_size 0.5 # ball goes to screem center      ball_speed = 80      direction = Vector2(-1, 0)    get_node("ball").set_pos(ball_pos)    # move left pad  var left_pos = get_node("left").get_pos()    if (left_pos.y > 0 and Input.is_action_pressed("left_move_up")):      left_pos.y += -PAD_SPEED delta  if (left_pos.y < screen_size.y and Input.is_action_pressed("left_move_down")):      left_pos.y += PAD_SPEED delta          get_node("left").set_pos(left_pos)          var right_pos = get_node("right").get_pos()  if (right_pos.y > 0 and Input.is_action_pressed("right_move_up")):      right_pos.y += -PAD_SPEED delta  if (right_pos.y < screen_size.y and Input.is_action_pressed("right_move_down")):      right_pos.y += PAD_SPEED delta                get_node("right").set_pos(right_pos)         # Called every time the node is added to the scene.  # Initialization here[/code]      The game loads, the pads work, but the ball just flies around everywhere. Hrmmmm

BinaryOrange

@SirBothersome:We do have code tags here, I have modified your posts to use them. Just click the hash (#) symbol in the post editor after selecting your code and it will automatically enclose the code with tags. Otherwise, you can manually do so by typing[b] [ code ] (your code here) [ /code ][/b], without the spaces in-between the square brackets.  ;)

Akien

[quote=SirBothersome][code]  var left_rect = Rect2( get_node("left").get_pos() - pad_size/2, pad_size )  var right_rect = Rect2( get_node("right").get_pos() - pad_size/2, pad_size)[/code][/quote]Be careful about that, if your pad_size is a vector of integers, [tt]pad_size/2[/tt] would give you a rounded value (e.g. if the pad width is 13, [tt]pad_size.x/2[/tt] would be 6). The proper way to get the half size here would be [tt]pad_size*0.5[/tt]. This should be fixed in the official tutorial :)Check the official pong demo and compare it with your script, I see some indentation issues at least: https://github.com/godotengine/godot-demo-projects/blob/master/2d/pong/pong.gdSeveral users are having troubles with the way the pong tutorial is written it seems, if you have suggestions for improvements, that would be very welcome :)

gungnirind

[quote author=Akien link=topic=15726.msg17230#msg17230 date=1469771522]Be careful about that, if your pad_size is a vector of integers, [tt]pad_size/2[/tt] would give you a rounded value (e.g. if the pad width is 13, [tt]pad_size.x/2[/tt] would be 6). The proper way to get the half size here would be [tt]pad_size0.5[/tt]. This should be fixed in the official tutorial :)[/quote]Note that [tt]pad_size/2.0[/tt] gives a float result just like [tt]pad_size0.5[/tt], but is perhaps a bit more intuitive, IMO :)

SirBothersome

[code]func _ready(): screen_size = get_viewport_rect().size # Get actual size pad_size = get_node("left").get_texture().get_size()set_process(true)[/code]Is missing {edit: placed near the beginning in}from the Godot.docs tutorial.  Also, the docs tut is confusing because the indentation isn't clearly marked, nor is there a final result of what the finished script should look like for comp/contr[quote] if you have suggestions for improvements, that would be very welcome :)[/quote] Mmm. Perhaps later. I'm already working on devel on something else. GBAGD

SirBothersome

Copy/pasted code from GItHub. Aside from syntax error on unindented Set_process(true), game works fine now. But the GH code is different from that of the docs  >:(