[SOLVED] Jump doesn't work

MYavuz

Can you please tell why this doesn't work? G: Note: I named a Static Body2D as 'Area2D'.

extends KinematicBody2D const gravity = 200.0 const speed = 200 const WALK_SPEED = 200 var velocity = Vector2() func ready(): set_fixed_process(true) get_node(&quot;../Area2D&quot;).connect(&quot;body_enter&quot;,self,&quot;on_Area2D_body_enter&quot;) get_node(&quot;../Area2D&quot;).connect(&quot;body_exit&quot;,self,&quot;on_Area2D_body_exit&quot;) func fixed_process(delta): &nbsp; &nbsp; velocity.y += delta gravity &nbsp; &nbsp; if (Input.is_action_pressed(&quot;ui_left&quot;)): &nbsp; &nbsp; &nbsp; &nbsp; velocity.x = - WALK_SPEED &nbsp; &nbsp; elif (Input.is_action_pressed(&quot;ui_right&quot;)): &nbsp; &nbsp; &nbsp; &nbsp; velocity.x =&nbsp; WALK_SPEED &nbsp; &nbsp; else: &nbsp; &nbsp; &nbsp; &nbsp; velocity.x = 0 if is_colliding(Area2D): if (Input_is_action_pressed(&quot;ui_up&quot;)): velocity.y = -200 &nbsp; &nbsp; var motion = velocity delta &nbsp; &nbsp; motion = move(motion) &nbsp; &nbsp; if (is_colliding()): &nbsp; &nbsp; &nbsp; &nbsp; var n = get_collision_normal() &nbsp; &nbsp; &nbsp; &nbsp; motion = n.slide(motion) &nbsp; &nbsp; &nbsp; &nbsp; velocity = n.slide(velocity) &nbsp; &nbsp; &nbsp; &nbsp; move(motion) func on_Area2D_body_enter( body ): print(&quot;Entered Area2D with body &quot;, body) func on_Area2D_body_exit( body ): print(&quot;Exited Area2D with body &quot;, body)

Battery

I thought this one would be a quick solve, but it actually proved a bit more difficult to figure out what was going wrong. You haven't told us much about your step up so I assume its a 2D platformer and everything else (collisions, left/right movement) is working as expected and properly set up. Here's what I think is happening:The first [tt]is_colliding()[/tt] check where you try to jump will always be false.To begin with there's no collision to register. Then you call [tt]move()[/tt], which moves the player and will register a collision and correct for it. So the second [tt]is_collision()[/tt] check will be true. At which point you call [tt]move()[/tt] again since any collision has already been corrected, this time when [tt]move()[/tt] is called there's no collision. So, when the script loops around again the first [tt]is_colliding()[/tt] check will be false and the jump code never executed. I hope that makes sense!This should work:[code]extends KinematicBody2Dconst gravity = 200const speed = 200const WALK_SPEED = 200var velocity = Vector2()func ready(): set_fixed_process(true)func fixed_process(delta): velocity.y += delta gravity print(self.is_colliding()) if (Input.is_action_pressed("ui_left")):     velocity.x = - WALK_SPEED elif (Input.is_action_pressed("ui_right")):     velocity.x =  WALK_SPEED else: velocity.x = 0 var motion = velocity delta if (is_colliding()): if (Input.is_action_pressed("ui_up")): velocity.y = -200 motion = velocity * delta else: var n = get_collision_normal() motion = n.slide(motion) move(motion)[/code]I think a ray cast node to check ground collisions would have also worked. Hope this helps!  :)

MYavuz

[quote author=Battery link=topic=15588.msg16693#msg16693 date=1465507848]I thought this one would be a quick solve, but it actually proved a bit more difficult to figure out what was going wrong. You haven't told us much about your step up so I assume its a 2D platformer and everything else (collisions, left/right movement) is working as expected and properly set up. Here's what I think is happening:The first [tt]is_colliding()[/tt] check where you try to jump will always be false.To begin with there's no collision to register. Then you call [tt]move()[/tt], which moves the player and will register a collision and correct for it. So the second [tt]is_collision()[/tt] check will be true. At which point you call [tt]move()[/tt] again since any collision has already been corrected, this time when [tt]move()[/tt] is called there's no collision. So, when the script loops around again the first [tt]is_colliding()[/tt] check will be false and the jump code never executed. I hope that makes sense!This should work:[code]extends KinematicBody2Dconst gravity = 200const speed = 200const WALK_SPEED = 200var velocity = Vector2()func ready(): set_fixed_process(true)func fixed_process(delta): velocity.y += delta gravity print(self.is_colliding()) if (Input.is_action_pressed("ui_left")):     velocity.x = - WALK_SPEED elif (Input.is_action_pressed("ui_right")):     velocity.x =  WALK_SPEED else: velocity.x = 0 var motion = velocity delta if (is_colliding()): if (Input.is_action_pressed("ui_up")): velocity.y = -200 motion = velocity delta else: var n = get_collision_normal() motion = n.slide(motion) move(motion)[/code]I think a ray cast node to check ground collisions would have also worked. Hope this helps!  :)[/quote]I already have solved it, but mine had problems. My game works better now. And, here is what i did before you posted it here.[code]extends KinematicBody2Dconst gravity = 200.00const speed = 200const WALK_SPEED = 200const JUMP_SPEED = 275var velocity = Vector2()func ready(): set_fixed_process(true)func fixed_process(delta):    if (Input.is_action_pressed("ui_up")):        velocity.y = - JUMP_SPEED    elif (Input.is_action_pressed("ui_down")):        velocity.y =  JUMP_SPEED gravity delta 2    else:        velocity.y += delta gravity 7    if (Input.is_action_pressed("ui_left")):        velocity.x = - WALK_SPEED    elif (Input.is_action_pressed("ui_right")):        velocity.x =  WALK_SPEED    else:        velocity.x = 0    var motion = velocity * delta    motion = move(motion)    if (is_colliding()):        var n = get_collision_normal()        motion = n.slide(motion)        velocity = n.slide(velocity)        move(motion)func on_Area2D_body_enter( body ): print("Entered Area2D with body ", body)func on_Area2D_body_exit( body ): print("Exited Area2D with body ", body) [/code]With that, player could fly or do infinite jumps. I may still use it though... But for the normal gameplay of the game, i will use the script you posted, thanks!  :)

Battery

:D Happy to help!An infinite jump/fly might be an interesting mechanic! Be sure to add solved to the topic title to help others looking on the forum.